fix(migrations): SpelLoadBalancersMigration runs on every migration #1070
Conversation
`isValid` returns true for `SpelLoadBalancersMigration` and there is no `VALID_UNTIL` set. Because of this, this migration runs regardless of the migration that were planning to run. I imagine the intent was originally to run this once, but in its current configuration, that is not true.
| import java.util.stream.Collectors; | ||
| import lombok.extern.slf4j.Slf4j; | ||
| import org.springframework.stereotype.Component; | ||
|
|
||
| @Component | ||
| @Slf4j | ||
| public class SpelLoadBalancersMigration implements Migration { | ||
| // Only valid until October 13th, 2021 | ||
| private static final Date VALID_UNTIL = new GregorianCalendar(2021, 10, 13).getTime(); |
There was a problem hiding this comment.
Sorry if I'm being dense, what's the significance of this date?
There was a problem hiding this comment.
No apologies necessary, it was just the day before I opened this PR, no significance at all really.
There was a problem hiding this comment.
I'm not familiar with migrations, is the intent that this migration should never run after this PR is merged and released? Is there a way to explicitly enable it after this PR?
Trying to understand if people on older versions of Spinnaker may have issues upgrading if this migration is skipped.
There was a problem hiding this comment.
If you look at some other examples of how Netflix has done migrations, they usually do them 1 of 2 ways - the way that I've done it with a specific date or with a ConditionalOnProperty. The benefit to doing it with a date like this is that you don't have to put up another PR to your config after you're done running the migration to disable it.
Trying to understand if people on older versions of Spinnaker may have issues upgrading if this migration is skipped.
That's a good question, this migration didn't actually do anything for us because we didn't have any pipelines (out of our thousands that we have) that met this condition.
Here are the PRs that should give a little more background on what the intent of this migration was for: #1025 and spinnaker/deck#8957
There was a problem hiding this comment.
Here's an example of an alternative way that migrations have been done
There was a problem hiding this comment.
I think we'll have to wait for @ajordens verdict - I'm not sure if this is a minor issue or a migration everybody needs to do.
isValidreturns true forSpelLoadBalancersMigrationand there is noVALID_UNTILset. Because of this, this migration runs regardless of the migration that were planning to run. I imagine the intent was originally to run this once, but in its current configuration, that is not true.