-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor improvements of manual_correction.py
#102
base: main
Are you sure you want to change the base?
Conversation
'-task-name', type=str, required=False, default='Manual', | ||
help= | ||
"R|The name of the task being done, which will be added in the json file. It must be added between \"\"." | ||
" For example: \"Manual correction of lesions generated from model XXX\" Default: \"Manual\"g.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To track such workflow (automatic segmentation by a model + manual correction), we add two entries into the JSON file (one for the model, the second for the rater). See here.
{
"SpatialReference": "orig",
"GeneratedBy": [
{
"Name": "sct_deepseg_sc",
"Version": "SCT v6.1"
},
{
"Name": "Manual",
"Author": "Nathan Molinier",
"Date": "2023-07-14 13:43:10"
}
]
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can specify the model's details using the -json-metadata
arg; see L246-L260
@plbenveniste, can you please try -json-metadata
arg on some of your corrections? I believe the output JSON sidecars will contain all the information you want to track.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Jan, sometimes we want to add multiple information to the sidecar and I believe the -json-metadata
flag accomplish that already
Please see #102 |
I made the two following changes:
-task-name
flag.Ready for review