Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename locale directory to locales #58

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Conversation

rffontenelle
Copy link
Collaborator

No description provided.

Copy link
Member

@shimizukawa shimizukawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rffontenelle
Copy link
Collaborator Author

Sorry for the force-push mess. Because the daily workflow ran, my commit renaming 'locale' directory to 'locales' caused merge conflict, so I had to do solve it. Then I did some house cleaning, putting .readthedocs.yml change into the same commit as. No new change, though.

For the record, Sphinx's own documentation defaults locale_dirs confval to 'locales' as of sphinx-doc/sphinx#13079.

@rffontenelle rffontenelle merged commit 45d98f0 into master Nov 4, 2024
11 of 16 checks passed
@rffontenelle rffontenelle deleted the rename-to-locales branch November 4, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants