Fix layout of logo. #191
Open
Fix layout of logo. #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having <h1> inside <p> led some browsers to believe that the HTML code was ill-formed. Thus, they inserted </p> before <h1>, causing the logo to be pushed away from the logo name.
silene
force-pushed
the
fix-logo-layout
branch
from
60b7bf5 to
a58f13a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having
<h1>inside<p>led some browsers (e.g., Firefox) to believe that the HTML code was ill-formed. Thus, they inserted</p>before<h1>, causing the logo to be incorrectly pushed away from the logo name. Below are screenshots showing the issue.Before the pull request:
After the pull request:
