Adjust page width in mobile to device width #157
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solve #139 and improve #140
I noticed the bug and investigated implementation of Sphinx. Related feature was added in Sphinx v1.7.0 and implemented on sphinx-doc/sphinx#4376 .
I think it's better to describe
mix-width
property in media queries and the value asunset
as this PR.Reasons
min-width and max-width of div.body are defined as theme options of basic theme. Because Alabaster inherit basic theme, end user can change the value like bellow. If static value is defined in alabaster.css, these options will be meaningless.
I think this sphinx feature (and basic theme) is assumed to be browsed on only PC browser and there is no need to have fixed value to these property on smartphone.
About other changes
When I tested this changes, I noticed that the sidebar width is not fit to widow size.