Remove underlines from badge elements.

Includes cherry-pick of 9c1fdac from #143
sphinx-doc · Oct 2, 2018 · a5496b2 · a5496b2
1 parent d7c124c
commit a5496b2
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/alabaster/about.html b/alabaster/about.html
@@ -31,7 +31,7 @@ <h1 class="logo"><a href="{{ pathto(master_doc) }}">{{ project }}</a></h1>
     {% set path = theme_travis_button %}
 {% endif %}
 <p>
-<a href="https://travis-ci.org/{{ path }}">
+<a class="badge" href="https://travis-ci.org/{{ path }}">
     <img
         alt="https://secure.travis-ci.org/{{ path }}.svg?branch={{ theme_badge_branch }}"
         src="https://secure.travis-ci.org/{{ path }}.svg?branch={{ theme_badge_branch }}"
@@ -47,7 +47,7 @@ <h1 class="logo"><a href="{{ pathto(master_doc) }}">{{ project }}</a></h1>
     {% set path = theme_codecov_button %}
 {% endif %}
 <p>
-<a href="https://codecov.io/github/{{ path }}">
+<a class="badge" href="https://codecov.io/github/{{ path }}">
     <img
     alt="https://codecov.io/github/{{ path }}/coverage.svg?branch={{ theme_badge_branch }}"
     src="https://codecov.io/github/{{ path }}/coverage.svg?branch={{ theme_badge_branch }}"

diff --git a/alabaster/static/alabaster.css_t b/alabaster/static/alabaster.css_t
@@ -221,6 +221,14 @@ div.sphinxsidebar hr {
     width: 50%;
 }
 
+div.sphinxsidebar .badge {
+    border-bottom: none;
+}
+
+div.sphinxsidebar .badge:hover {
+    border-bottom: none;
+}
+
 /* -- body styles ----------------------------------------------------------- */
 
 a {

diff --git a/docs/changelog.rst b/docs/changelog.rst
@@ -2,6 +2,9 @@
 Changelog
 =========
 
+- :bug:`-` On some browsers/platforms, 'badge'-style sidebar elements were
+  displaying dotted underlines. This was unintentional and explicit styling has
+  been added to remove them. Credit to Steven Loria.
 - :bug:`128` Remove Gittip/Gratipay output from the ``donation.html`` sidebar
   component, since the actual service has been insolvent since 2017. The
   configuration options remain in place for the time being (to avoid breaking