Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bash): Fix bash completion for suggestions that contain special characters. #2126

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(bash): Fix bash completion for suggestions that contain special characters. #2126

wants to merge 3 commits into from

Commits on Mar 21, 2024

  1. fix(bash): Fix bash completion for suggestions that contain special c… 

    …haracters.

Special characters include whitepace, so this is more general than
 spf13#1743. This should also fix spf13#1740.

I added some test cases to cobra-completion-testing. This PR makes them
pass. It also doesn't trip any of the performance regression tests. I'm
happy to submit those tests as a PR as well.
  - https://github.com/JeffFaer/cobra-completion-testing/tree/special_characters
  - JeffFaer/cobra-completion-testing@52254c1
    @JeffFaer
    JeffFaer committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    3c78872 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. fix: We don't need an extra empty character when we're doing proper q… 

    …uoting.
    @JeffFaer
    JeffFaer committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    fcc5b8c View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Don't quote different completion types. 

    They're not going through compgen so they don't need it.
    @JeffFaer
    JeffFaer committed May 1, 2024
    Configuration menu
    Copy the full SHA
    9ac0f55 View commit details
    Browse the repository at this point in the history