Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: --send-all option #23

Open
wants to merge 3 commits into
base: dev-0.3.17
Choose a base branch
from

Conversation

x100111010
Copy link
Member

@x100111010 x100111010 commented Oct 26, 2024

  • added --send-all option to send command, allowing users to send their entire mature balance minus an optional priority fee
  • retains feature parity between Go and Rust implementations (the Go wallet has --send-all)
  • fix formatting and typos

* added `--send-all` option to `send` command, allowing users to send their entire mature balance minus an optional priority fee
* retains feature parity between Go and Rust implementations (the Go node has `--send-all`)
@x100111010
Copy link
Member Author

I can also confirm that it works, as I've tested it on our testnet:

Test [c500ac46] • 3,587.9997784 TSPR (180 TSPR) $ send spectretest:qpr45ckkggwygdxdg7jxzkqcpd26s7q9rg0mxzncv90wy9hps8e0vhlq4j0dt --send-all
Enter wallet password:
Transaction sent - Amount: 3,587.9997784 TSPR  Fees: 0.00057936 TSPR  Total: 3,588.00035776 TSPR  UTXOs: 51

Sending 3,587.9997784 SPR to spectretest:qpr45ckkggwygdxdg7jxzkqcpd26s7q9rg0mxzncv90wy9hps8e0vhlq4j0dt

With priority fee:

Test [c500ac46] • 228.02882758 TSPR (240 TSPR) $ send spectretest:qpr45ckkggwygdxdg7jxzkqcpd26s7q9rg0mxzncv90wy9hps8e0vhlq4j0dt --send-all 2
Enter wallet password:
Transaction sent - Amount: 226.02882758 TSPR  Fees: 2.0002216 TSPR  Total: 228.02904918 TSPR  UTXOs: 19

Sending 226.02882758 SPR to spectretest:qpr45ckkggwygdxdg7jxzkqcpd26s7q9rg0mxzncv90wy9hps8e0vhlq4j0dt

* added `\n` newline for some space between displayed txids
@x100111010 x100111010 changed the base branch from main to dev-0.3.17 October 28, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant