Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as per request #160

Merged
merged 6 commits into from
Aug 9, 2024
Merged

as per request #160

merged 6 commits into from
Aug 9, 2024

Conversation

YannChemin
Copy link

@YannChemin YannChemin commented Oct 17, 2023

Loads Relab library basic info, does not load type, class and subclass
some code using ignorefiles is not needed

@LaurentBerder
Copy link

LaurentBerder commented Jun 10, 2024

@tboggs, I have extensively tested it, and it works very well.
Can we merge it in the master?

@YannChemin
Copy link
Author

Hi @tboggs, any update on this side?

@tboggs
Copy link
Member

tboggs commented Jul 31, 2024

Hi @YannChemin, apologies for the delay. I'm away from my dev system for a few days. I'll review & test this by next week.

@tboggs
Copy link
Member

tboggs commented Aug 5, 2024

The code looks good to me but before merging to master, please add some basic unit tests for creating and querying a Relab database. You should be able to copy most of the test code from one of the other databases in this file (you can also add the unit tests to the same file).

@YannChemin
Copy link
Author

This is done, test added

@YannChemin
Copy link
Author

@tboggs

@tboggs
Copy link
Member

tboggs commented Aug 7, 2024

@YannChemin Thanks for adding the unit tests. I will have time to test the code in the next day or two and merge into master.

In the meantime, could you please rename the relabDatabase class to RelabDatabase to maintain pep8 compliance for class names?

@YannChemin
Copy link
Author

OK done @tboggs

@tboggs
Copy link
Member

tboggs commented Aug 9, 2024

@YannChemin, I'm ready to look at this now. Are PR #158 and #160 identical, just merging to different branches?

@tboggs tboggs merged commit c620527 into spectralpython:develop Aug 9, 2024
3 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants