Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compound-expression from ABNF grammar #889

Closed
wants to merge 1 commit into from

Conversation

sertonix
Copy link

@sertonix sertonix commented Feb 26, 2024

compound-expression was equivalent to license-expression. Also fixing a small formatting issue.

Ref #62, #456

@goneall
Copy link
Member

goneall commented Apr 4, 2024

Thanks @sertonix for the pull request.

Can you apply this to the development/v3.0 branch and sign off so it passes the DCO?

@zvr
Copy link
Member

zvr commented Apr 4, 2024

@goneall I don't agree this is needed.

Yes, license-expression can be expanded to the same as compound-expression, but this was chosen to illustrate the different types of expressions. The text below follows this convention, talking about simple and compound/complex expressions.

@sertonix
Copy link
Author

sertonix commented Apr 4, 2024

The text below follows this convention, talking about simple and compound/complex expressions.

Couldn't the text talk about simple expressions and license expressions instead?

@goneall
Copy link
Member

goneall commented Apr 4, 2024

@goneall I don't agree this is needed.

Yes, license-expression can be expanded to the same as compound-expression, but this was chosen to illustrate the different types of expressions. The text below follows this convention, talking about simple and compound/complex expressions.

This makes sense - I'm OK with the way it is (even though, technically, it can be removed).

@sertonix if you're OK with this, we can close this PR (and you don't need to rebase).

@sertonix sertonix changed the base branch from development/v2.3.1 to development/v3.0 April 4, 2024 21:33
@zvr
Copy link
Member

zvr commented Apr 4, 2024

Couldn't the text talk about simple expressions and license expressions instead?

But "simple expressions" are also "license expressions" -- they are not two distinct things.

Having the grammar was confusing enough for lawyers who have to read this (and who wrote this), so we wanted to make it crystal clear and easy to follow.

@goneall
Copy link
Member

goneall commented Apr 6, 2024

Going to go ahead and close this per @zvr comment above

@goneall goneall closed this Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants