Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese Translation (partial) #1138

Closed

Conversation

koizumistr
Copy link

No description provided.

@bact
Copy link
Collaborator

bact commented Oct 19, 2024

The DCO check failed because the commit messages need a sign off line
(signed-off-by: Name <[email protected]>)

https://docs.pi-hole.net/guides/github/how-to-signoff/ give a good example on how to sign off

Every commit from every branch that will construct this PR needs the sign off line.

@bact
Copy link
Collaborator

bact commented Oct 19, 2024

There are currently 3 warnings:

WARNING - The following pages exist in the docs directory, but are not included in the "nav" configuration:

  • ja/index.md
  • ja/scope.md
  • ja/annexes/spdx-lite.md
  • ja/front/copyright.md
  • ja/front/introduction.md

WARNING - Doc file 'ja/front/copyright.md' contains a link '../licenses/Community-Spec-1.0.md', but the target 'ja/licenses/Community-Spec-1.0.md' is not found among documentation files.

WARNING - Doc file 'ja/front/copyright.md' contains a link '../licenses/CC-BY-3.0.md', but the target 'ja/licenses/CC-BY-3.0.md' is not found among documentation files.

  1. The latter two can be fixed (not elegantly) by just copy the license directory from en to ja.

  2. The first one is not related to the content of this PR and needs to be fixed at the other level.
    It looks like we may need to:

    • Have labels in nav section in different languages
    • Translate site_description and/or site_name

    Which means a single (or static) mkdocs.yml is no longer sufficient to support multiple language.

    We can probably use this Setting up multi-language installations squidfunk/mkdocs-material#2346 as an example for discussion

--

For this particular PR, I think fixing (1) is already enough. (2) is not relevant for the translation in this PR (except those page titles in mkdocs.yml, which can be handle separately in another PR).

@koizumistr
Copy link
Author

@bact
Thank you for reviewing.
As you say, we made a mistake with the DCO. So we will resubmit this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation: ja Translation for Japanese language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants