Fix attribute mutators

[vencelkatai]

Hi,

Issue

Since the latest version, attribute mutators of translated attributes are getting called twice when getting the translated value.
It is happening because the following change in PR #465 in the getTranslation method:

// if column value is `null` then we have nothing to do, return `null`
if (is_null(parent::getAttributeValue($key))) {
    return null;
}

parent::getAttributeValue will try to transform the value using the attribute, which causes it to be called with the raw value stored in the database.

It wouldn't be a big issue but in my case I have a translated date which I'd like to parse into Carbon.
For example:

use Carbon\Carbon;
use Illuminate\Database\Eloquent\Casts\Attribute;
use Illuminate\Database\Eloquent\Model;
use Spatie\Translatable\HasTranslations;

class Example extends Model
{
    use HasTranslations;

    public $translatable = ['date'];

    /** @return Attribute<Carbon, never> */
    public function date(): Attribute
    {
        return Attribute::get(fn ($value) => Carbon::parse($value));
    }
}

Getting the value raises an exception in this case:

$example = new Example();
$example->date = now();
$example->save();

$example->date; // Should be a Carbon object

Could not parse '{"en":"2024-12-10T20:01:47.992298Z"}'

I have added a simple test to reproduce the issue, you can see that it is getting called with the raw value first:

Fix

This PR solves this issue by using the untransformed value for the null check instead.

[freekmurze]

Thanks!