Improve setAttribute
to handle array list as value for translation
#469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the
setAttribute
method in theHasTranslations
trait to handle array values for translatable attributes.Motivation
Previously, setting an array value for a translatable attribute would result in unexpected behavior, treating array indexes as locale keys. For example:
Would store:
With this change, the array is now stored as a translation for the current locale:
Tests were added to verify the correct behavior of the
setAttribute
method with array values.