Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Select signal inputs #493

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

elite-benni
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • accordion
  • alert
  • alert-dialog
  • aspect-ratio
  • avatar
  • badge
  • button
  • calendar
  • card
  • checkbox
  • collapsible
  • combobox
  • command
  • context-menu
  • data-table
  • date-picker
  • dialog
  • dropdown-menu
  • hover-card
  • icon
  • input
  • label
  • menubar
  • navigation-menu
  • pagination
  • popover
  • progress
  • radio-group
  • scroll-area
  • select
  • separator
  • sheet
  • skeleton
  • slider
  • sonner
  • spinner
  • switch
  • table
  • tabs
  • textarea
  • toast
  • toggle
  • tooltip
  • typography

What is the current behavior?

Disabled Options don't look disabled and are clickable.

Input, Output, ViewChild, ContentChild are in the old @decorator format.

Closes #452
Closes #429

What is the new behavior?

Disabled Options are not clickable anymore and appear as disabled.

Refactoring
Input, Output, ViewChild, ContentChild are now Signal/Function based.

Does this PR introduce a breaking change?

  • Yes
  • No

As all the other refactorings to signal inputs it is not possible anymore to write directly to inputs.
Writing to inputs was never really recommended by the angular team.

Other information

@elite-benni elite-benni changed the title Selectsignals refactor: Select signal inputs Nov 21, 2024
@elite-benni elite-benni mentioned this pull request Nov 21, 2024
57 tasks
@benpsnyder
Copy link
Collaborator

@elite-benni please run nx format and push

@elite-benni
Copy link
Collaborator Author

I am pretty sure, that I did that and nx format does not change anything in my code.
The linting error is not in the code but in the commit message.
I am not sure why I could commit with this typo "fix(seleect): tests" in the first place. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disabled don't work on hlm-option refactor(select): migration to signals
2 participants