refactor(tabs): use signal contentChildren for paginated tabs #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetzrobin
approved these changes
Nov 21, 2024
goetzrobin
reviewed
Nov 21, 2024
Comment on lines
65
to
66
| public _items = contentChildren(BrnTabsTriggerDirective, { descendants: false }); | ||
| public _itemsChanges = toObservable(this._items); |
There was a problem hiding this comment.
should these be readonly?
There was a problem hiding this comment.
Yes! Updated the code
* remove additional padding for pagination buttons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
guidelines: https://github.com/goetzrobin/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Closes #436
What is the new behavior?
Does this PR introduce a breaking change?
HlmTabsPaginatedListComponentmust be updated to usecontenChildren.Other information
Tab changes work fine with keyboard and also with the arrow buttons.