Add Windows/Mac compatibility, implement the UBX-RXM-RAWX message, fix timeout bug. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 25, 2020 17:31
…ss it. Added pyserial to the requirements Added timeout for the _read_until method Added a SerialException for the _read_until method failing to find a terminator. Add the message dictionary that indicates the code for the RAWX message Added RXM_CLS to the list of predefined classes
fixed a typo
|
I just looked at PR #10 and the separate NMEA/UBX parsing may make the timeout bug that I found difficult to replicate. I was seeing a bunch of NMEA messages come over the serial port when it missed the terminator, so it is possible that splitting NMEA and UBX would fix everything. |
|
@edspark Is there anything that you need before considering this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes 3 distinct changes.
spidevmodule that functions natively on Mac or Windows. I added code to bypass the SPI functionality if not on a linux system. A useful warning when this bypass is triggered.core.Parse._read_until()static method will continue to read until it finds a terminator. However this method bypasses the timeout, so if the read misses the terminator, then it will continue indefinitely. I used the timeout defined by thestreaminput to act as a timeout for the read. If the timeout is reached before the terminator is found, a SerialException is raised.These changes were tested on a F9P and M8N. (Note the M8N doesn't support RAWX)