feat: Support all resvg options #12
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
commented
Apr 18, 2023
| pytest.param( | ||
| "resources/examples/svg/octocat.svg", | ||
| resvg_py.SVGOptions( | ||
| shape_rendering=resvg_py.ShapeRendering.GeometricPrecision, |
There was a problem hiding this comment.
@jboarman Do you have handy examples of input/output pairs that might be worth testing here?
There's a bunch of examples in the upstream Rust repo, but it's probably overkill to check all of them.
There was a problem hiding this comment.
Until we implement the benchmark in issue #10, I think we can make use of a few random selections from the upstream repo that you identified in your comment.
There was a problem hiding this comment.
Alright, I'll try to port a few of the test files to validate the options.
|
@jboarman You added this to the readme: from resvg import Options, render_from_file
options = Options()
options.width = 300
options.height = 200
options.background = "#FFAABB"
options.dpi = 96.0
options.languages = ["en", "fr", "es"]
options.shape_rendering = "optimizeSpeed"
options.text_rendering = "optimizeLegibility"
options.image_rendering = "optimizeQuality"
output_image = render_from_file("input.svg", options)is that the API you expect, with an end-to-end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.