example: HTML escape WHOIS registrant data #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
It is possible for WHOIS registrant data to include HTML tags. Many domain registrars will sanitise this input, however it is relatively simple to add HTML to the remarks section of WHOIS data if you control an Autonomous System or IP block.
The example script in this repo does not escape the
$result['rawdata']
and thus if HTML is included within the WHOIS response, it is directly rendered on the page if the script is invoked as followsexample.php?query=AS_NUMBER
.I have reproduced this behaviour locally.
What does this PR do?
$result['rawdata']
to make sure that a WHOIS response does not cause HTML from that response to be renderedExample
For example, without the fix, this query can change the stying of the page to blue rather than white.