Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.13 support #394

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Python 3.13 support #394

merged 4 commits into from
Sep 5, 2024

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Sep 4, 2024

Description

This pull request is to

@pllim pllim added this to the 1.4.0 milestone Sep 4, 2024
Copy link

github-actions bot commented Sep 4, 2024

Thank you for your contribution! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the STScI coding guidelines?
  • Are tests added/updated as required? If so, do they follow the STScI testing guidelines?
  • Are docs added/updated as required?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions.
  • Did the CI pass? If no, are the failures related?
  • Is a change log needed?

Copy link

github-actions bot commented Sep 4, 2024

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

but have to relax the comparison because OSX gives different numbers

MNT: Add Python 3.13 support
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.19%. Comparing base (570f216) to head (bc912f7).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
- Coverage   97.21%   97.19%   -0.03%     
==========================================
  Files          17       17              
  Lines        2047     2031      -16     
==========================================
- Hits         1990     1974      -16     
  Misses         57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim pllim added the Build wheels Test wheels on PR label Sep 5, 2024
@pllim pllim marked this pull request as ready for review September 5, 2024 01:36
@pllim pllim merged commit 7034d1a into spacetelescope:master Sep 5, 2024
25 of 26 checks passed
@pllim pllim deleted the py313 branch September 5, 2024 01:38
@pllim pllim mentioned this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST: Run filter_par.rst with numpy>=2
1 participant