-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCSB-155] build with Numpy 2.0 release candidate #388
[SCSB-155] build with Numpy 2.0 release candidate #388
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #388 +/- ##
==========================================
- Coverage 97.21% 97.19% -0.03%
==========================================
Files 17 17
Lines 2047 2031 -16
==========================================
- Hits 1990 1974 -16
Misses 57 57 ☔ View full report in Codecov by Sentry. |
numpy>=2.0.0rc2
in build-system.requires
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But why? What is the difference between RC1 and RC2? Why not just wait for numpy 2 stable that is coming out in a few weeks?
well, I would like to have a build with some version of the 2.0 ABI before the full Numpy 2.0 release, to head off installation issues for users who don't have Numpy pinned, and so we can test along our dependency web; unfortunately, it looks like even if you build against numpy 2.0, if you depend on an upstream project built against numpy 1.x there will be issues |
Yes, that is true whether it is RC1 or RC2. The whole chain needs to be either all on 1.x ABI or all on 2.x ABI. |
For |
good point, in this case since it's already |
No worries! |
Yes, oldest-supported-numpy is incompatible with numpy 2.0 stuff. |
Description
resolves SCSB-155
Numpy 2.0 is scheduled for release on June 19th. Due to the C ABI updates, Python projects that build C extensions are required to build against Numpy 2.0 in order to use Numpy 2.0 in runtime.
This is backwards-compatible with Numpy versions in runtime as far back as
1.26
this PR pins
numpy>=2.0.0rc2
inbuild-system.requires
Note
this PR was generated automatically by
batchpr
🤖