Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCSB-155] build with Numpy 2.0 release candidate #388

Conversation

zacharyburnett
Copy link
Contributor

Description

resolves SCSB-155

Numpy 2.0 is scheduled for release on June 19th. Due to the C ABI updates, Python projects that build C extensions are required to build against Numpy 2.0 in order to use Numpy 2.0 in runtime.
This is backwards-compatible with Numpy versions in runtime as far back as 1.26

this PR pins numpy>=2.0.0rc2 in build-system.requires

Note

this PR was generated automatically by batchpr 🤖

Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.19%. Comparing base (570f216) to head (18f0731).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage   97.21%   97.19%   -0.03%     
==========================================
  Files          17       17              
  Lines        2047     2031      -16     
==========================================
- Hits         1990     1974      -16     
  Misses         57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett zacharyburnett changed the title pin numpy>=2.0.0rc2 in build-system.requires [SCSB-155] build with Numpy 2.0 release candidate May 31, 2024
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why? What is the difference between RC1 and RC2? Why not just wait for numpy 2 stable that is coming out in a few weeks?

@pllim pllim closed this Jun 3, 2024
@zacharyburnett
Copy link
Contributor Author

But why? What is the difference between RC1 and RC2? Why not just wait for numpy 2 stable that is coming out in a few weeks?

well, I would like to have a build with some version of the 2.0 ABI before the full Numpy 2.0 release, to head off installation issues for users who don't have Numpy pinned, and so we can test along our dependency web; unfortunately, it looks like even if you build against numpy 2.0, if you depend on an upstream project built against numpy 1.x there will be issues

@pllim
Copy link
Contributor

pllim commented Jun 3, 2024

if you depend on an upstream project built against numpy 1.x there will be issues

Yes, that is true whether it is RC1 or RC2. The whole chain needs to be either all on 1.x ABI or all on 2.x ABI.

@pllim
Copy link
Contributor

pllim commented Jun 3, 2024

For synphot, it is already using numpy 2.0 ABI both on PyPI and conda-forge . I don't see why RC2 would matter. I am just waiting for numpy 2.0 stable coming out in a few weeks.

@zacharyburnett
Copy link
Contributor Author

good point, in this case since it's already rc1 it doesn't really matter. Sorry, I was confusing this with another project that was using oldest-supported-numpy; too many PRs! 😅

@pllim
Copy link
Contributor

pllim commented Jun 3, 2024

No worries!

@pllim
Copy link
Contributor

pllim commented Jun 3, 2024

Yes, oldest-supported-numpy is incompatible with numpy 2.0 stuff.

@zacharyburnett zacharyburnett deleted the pin_numpy_build_requirement branch June 3, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants