Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Bump checkout version and add Python 3.12 #365

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Sep 22, 2023

Description

This pull request is to fix #364

and add Python 3.12 job
@pllim pllim added this to the 1.3.0 milestone Sep 22, 2023
@github-actions
Copy link

Thank you for your contribution! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the STScI coding guidelines?
  • Are tests added/updated as required? If so, do they follow the STScI testing guidelines?
  • Are docs added/updated as required?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions.
  • Did the CI pass? If no, are the failures related?
  • Is a change log needed?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.

@github-actions
Copy link

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim
Copy link
Contributor Author

pllim commented Sep 22, 2023

What? All green on first try? For once the stack isn't trying to send me to an early grave.

@pllim pllim marked this pull request as ready for review September 22, 2023 15:28
@pllim pllim merged commit 9235387 into spacetelescope:master Sep 22, 2023
19 checks passed
@pllim pllim deleted the py312 branch September 22, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.12 support
1 participant