Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update romanisim to use the new L1 / L2 metadata #166

Merged
merged 19 commits into from
Oct 30, 2024

Conversation

schlafly
Copy link
Collaborator

We are updating the metadata in rad/rdm for L1 and L2 files. This updates romanisim to use that new metadata format. It also changes the file names to use wfi in lowercase rather than uppercase.

@schlafly schlafly requested a review from a team as a code owner October 18, 2024 19:01
@schlafly schlafly marked this pull request as draft October 18, 2024 19:02
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.00%. Comparing base (81028a8) to head (1a4d87e).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
romanisim/ris_make_utils.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   89.24%   91.00%   +1.76%     
==========================================
  Files          17       16       -1     
  Lines        2073     2102      +29     
==========================================
+ Hits         1850     1913      +63     
+ Misses        223      189      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schlafly
Copy link
Collaborator Author

@PaulHuwe , I think this is basically working; tests are currently failing because BORESIGHT / WFI_CEN / CGI_CEN aren't allowed aperture names, but I think we want to add those to the allowed list. When the new rad/rdm PRs go in we'll want to use this PR to make the L1 data that can be used for the romancal regression tests.

@schlafly
Copy link
Collaborator Author

Okay, this is now ready to go when we merge the rad/rdm changes.

@schlafly schlafly marked this pull request as ready for review October 30, 2024 13:51
@schlafly schlafly merged commit c07b7b8 into spacetelescope:main Oct 30, 2024
22 checks passed
@schlafly schlafly deleted the l1-l2-refactor-no-unit branch October 30, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant