handle case where romancal is installed with -e

[zacharyburnett]

prevent this mistake from happening again:

romancal/requirements-sdp.txt

Line 91 in 61b3f91

-e file:///Users/zburnett/projects/romancal

Tasks

• request a review from someone specific, to avoid making the maintainers review every PR
• add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
• Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
  • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • start a regression test and include a link to the running job (click here for instructions)
    • Do truth files need to be updated ("okified")?
      • after the reviewer has approved these changes, run okify_regtests to update the truth files
• if a JIRA ticket exists, make sure it is resolved properly

news fragment change types...

• changes/<PR#>.general.rst: infrastructure or miscellaneous change
• changes/<PR#>.docs.rst
• changes/<PR#>.stpipe.rst
• changes/<PR#>.associations.rst
• changes/<PR#>.scripts.rst
• changes/<PR#>.mosaic_pipeline.rst
• changes/<PR#>.patch_match.rst

steps

• changes/<PR#>.dq_init.rst
• changes/<PR#>.saturation.rst
• changes/<PR#>.refpix.rst
• changes/<PR#>.linearity.rst
• changes/<PR#>.dark_current.rst
• changes/<PR#>.jump_detection.rst
• changes/<PR#>.ramp_fitting.rst
• changes/<PR#>.assign_wcs.rst
• changes/<PR#>.flatfield.rst
• changes/<PR#>.photom.rst
• changes/<PR#>.flux.rst
• changes/<PR#>.source_detection.rst
• changes/<PR#>.tweakreg.rst
• changes/<PR#>.skymatch.rst
• changes/<PR#>.outlier_detection.rst
• changes/<PR#>.resample.rst
• changes/<PR#>.source_catalog.rst

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.68%. Comparing base (c92c48c) to head (79a3f88).
Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1522   +/-   ##
=======================================
  Coverage   76.68%   76.68%           
=======================================
  Files         120      120           
  Lines        7832     7832           
=======================================
  Hits         6006     6006           
  Misses       1826     1826           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[ddavis-stsci]

I think that this just removes romancal from the requirements-sdp file and I'm not sure that is what SDF needs.

[zacharyburnett]

I think that this just removes romancal from the requirements-sdp file and I'm not sure that is what SDF needs.

I think that's exactly what they want, though; the instructions in requirements-sdp.txt remove romancal.git already. At the moment, we don't delivery requirements-sdp.txt to SDF, but rather an environment created from it PLUS the local installation of romancal. I'm not sure why this is the case; perhaps stasis is a good opportunity to revisit that flow.

[ddavis-stsci]

If its SDF you're worried about they want the -e to be removed from the reqs_stable-deps.txt file. As I understand it this uses a tmp area and they no longer have access to /tmp or maybe /var?

The requirements-sdf.txt file is used for external users to build and environment that matches the SDF one. However, I cannot test this at the moment. Well I can but I just don't get very far because the install fails with

  ERROR: Failed building wheel for spherical-geometry
  Building editable for romancal (pyproject.toml) ... done
  Created wheel for romancal: filename=romancal-0.14.1.dev649+g01392a3-0.editable-py3-none-any.whl size=10214 sha256=4bbbf6ac02ffd0bafcffb56ec9f0bc466e51c348d1d71010f82e4a8245f294a9
  Stored in directory: /private/var/folders/p6/1_313qjs3kd6dxj7cwwp11k40001h7/T/pip-ephem-wheel-cache-ti5530lz/wheels/9c/a9/f1/35e2e8a04683507e77d81a0506f09dede4906335851ebbdda4
Successfully built romancal
Failed to build spherical-geometry
ERROR: ERROR: Failed to build installable wheels for some pyproject.toml based projects (spherical-geometry)