rcal-949 Update file naming and asn header coords

[ddavis-stsci]

Resolves RCAL-949

Closes #1501

This PR updates the the file naming conventions and adds the orientation to the wcs keywords in the asn header.

Tasks

• request a review from someone specific, to avoid making the maintainers review every PR
• add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
• [z] Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
  • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • start a regression test and include a link to the running job (click here for instructions)
    https://github.com/spacetelescope/RegressionTests/actions/runs/11783036917
    • [N/A] Do truth files need to be updated ("okified")?
      • after the reviewer has approved these changes, run okify_regtests to update the truth files
• if a JIRA ticket exists, make sure it is resolved properly

news fragment change types...

• changes/<PR#>.general.rst: infrastructure or miscellaneous change
• changes/<PR#>.docs.rst
• changes/<PR#>.stpipe.rst
• changes/<PR#>.associations.rst
• changes/<PR#>.scripts.rst
• changes/<PR#>.mosaic_pipeline.rst
• changes/<PR#>.patch_match.rst

steps

• changes/<PR#>.dq_init.rst
• changes/<PR#>.saturation.rst
• changes/<PR#>.refpix.rst
• changes/<PR#>.linearity.rst
• changes/<PR#>.dark_current.rst
• changes/<PR#>.jump_detection.rst
• changes/<PR#>.ramp_fitting.rst
• changes/<PR#>.assign_wcs.rst
• changes/<PR#>.flatfield.rst
• changes/<PR#>.photom.rst
• changes/<PR#>.flux.rst
• changes/<PR#>.source_detection.rst
• changes/<PR#>.tweakreg.rst
• changes/<PR#>.skymatch.rst
• changes/<PR#>.outlier_detection.rst
• changes/<PR#>.resample.rst
• changes/<PR#>.source_catalog.rst

[codecov]

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 76.24%. Comparing base (0579dac) to head (6043bf6).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
romancal/associations/skycell_asn.py	12.50%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1505      +/-   ##
==========================================
- Coverage   76.26%   76.24%   -0.02%     
==========================================
  Files         115      115              
  Lines        7643     7650       +7     
==========================================
+ Hits         5829     5833       +4     
- Misses       1814     1817       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[schlafly]

Thanks Dave. This looks good. Harry made a further update to the file names to remove the wfi string from the L3 products.
e.g.
rPPPPP_p_v0102010001001_274p63x31y81_f106_coadd.asdf
https://innerspace.stsci.edu/pages/viewpage.action?spaceKey=RDMSDOC&title=Roman+Science+File+Naming+Conventions+for+Files+in+the+Archive+Catalog
I think this just means re-removing the +instrument and a +sep.

[mairanteodoro]

Looks good to me.
I only left one suggestion that would make the code more maintainable.

[mairanteodoro]

I think the code would be more concise and easier to maintain if we used a mapping instead of a conditional block here. Something along the lines of:

product_name_mapping = {
    "visit": "v" + parsed_visit_id[1] + parsed_visit_id[...] + parsed_visit_id[n],
    "daily": "d" + parsed_visit_id[1] + parsed_visit_id[...] + parsed_visit_id[n],
    "pass": "p" + parsed_visit_id[1] + parsed_visit_id[...] + parsed_visit_id[n],
    "full": "full",
    "user": "user"
}

pr_name = product_name_mapping.get(product_type, "unknown")

[mairanteodoro]

Looks good! Thanks.