Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAD-187: ePSF Schema Update #507

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

PaulHuwe
Copy link
Collaborator

Resolves RAD-187

Closes #501

This PR updates the ePSF schema.

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)
News fragment change types:
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.81%. Comparing base (af9de57) to head (106b883).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #507   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files           4        4           
  Lines         215      215           
=======================================
  Hits          206      206           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaulHuwe PaulHuwe marked this pull request as ready for review November 12, 2024 03:07
@schlafly
Copy link
Collaborator

Tyler is at a meeting this week so I doubt he'll weigh in. We don't currently make these files so this is good to have in B16 but isn't critical. On the other hand, I don't think it has any regtest / downstream code implications, so I'd go ahead and merge when you're ready.

@PaulHuwe PaulHuwe merged commit b6ac883 into spacetelescope:main Nov 12, 2024
12 checks passed
@PaulHuwe PaulHuwe deleted the RAD-501_ePSFUpdate branch November 12, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ePSF Schema Update
2 participants