RAD-502: CRDS Keywords Not Required #506
Conversation
PaulHuwe
requested review from
kdupriestsci,
jbrookens,
WilliamJamieson and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #506 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 4 4
Lines 215 215
=======================================
Hits 206 206
Misses 9 9 ☔ View full report in Codecov by Sentry. |
|
This looks like a duplicate of #505 |
| @@ -171,4 +172,5 @@ properties: | |||
| datatype: nvarchar(120) | |||
| destination: [ScienceRefData.r_refpix, GuideWindow.r_refpix, WFICommon.r_refpix] | |||
| flowStyle: block | |||
| required: [crds, dark, distortion, mask, flat, gain, readnoise, linearity, photom, area, saturation, refpix] | |||
There was a problem hiding this comment.
Do you know whether this breaks existing files?
There was a problem hiding this comment.
Not offhand - given that the other change will break files, I didn't look
There was a problem hiding this comment.
Okay. Let's wait until after standup and I ping Melissa about any other issues she may have identified. But then let's limit this to the minimum change to fix the problem (just making the two crds keywords required, I think?), and then merge unless there are more problems identified.
I think the other required changes are good but but aren't necessary to get things to work.
There was a problem hiding this comment.
Does romancal also need a PR to update where the crds information is assigned?
https://github.com/spacetelescope/romancal/blob/8a04f5a2b604eee12c10a4a2cd7ca96312523b5a/romancal/stpipe/core.py#L90-L91
There was a problem hiding this comment.
I think so - we know that files will need to be remade with these changes.
|
Yes, it will. |
Resolves RAD-1234
Closes #502
This PR adds CRDS and reference steps required lists.
Tasks
radtests.docs/page.no-changelog-entry-needed.)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types).romancalregression test (https://github.com/spacetelescope/RegressionTests/actions/workflows/romancal.yml) with this branch installed ("git+https://github.com/<fork>/rad@<branch>").roman_datamodelsutilities and tests.News fragment change types:
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change