RAD-184: Update Individual Image Meta and Misc #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
… RAD-93_WCSInfo
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…aulHuwe/rad into RAD-184_IMMandL1L2Updates
…o RAD-184_IMMandL1L2Updates
… RAD-184_IMMandL1L2Updates
…-86_ExposureProgram
… RAD-184_IMMandL1L2Updates
…to RAD-184_IMMandL1L2Updates
PaulHuwe
requested review from
kdupriestsci,
WilliamJamieson and
a team
as code owners
kdupriestsci
reviewed
Nov 1, 2024
| the RCS is on, and "N/A" if the RCS is off. | ||
| anyOf: | ||
| - type: string | ||
| enum: ["A", "B", None] |
There was a problem hiding this comment.
description says values can be "A", "B", or "N/A" but enum says "A", "B", None. I see this in more than one spot. Is something somewhere translating "N/A" to None?
There was a problem hiding this comment.
@tddesjardins We missed this in the doc - do you want to update the doc, or do you need changes in the schema?
| type: integer | ||
| enum: [-1, 1] |
There was a problem hiding this comment.
if values can only be -1 and 1 then perhaps change the archive datatype from int to smallint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RAD-184
Closes #486
This PR updated individual meta and misc and cleans up merge issues from the suite of L1 & L2 metadata update pull requests.
Tasks
radtests.docs/page.no-changelog-entry-needed.)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types).romancalregression test (https://github.com/spacetelescope/RegressionTests/actions/workflows/romancal.yml) with this branch installed ("git+https://github.com/<fork>/rad@<branch>").roman_datamodelsutilities and tests.News fragment change types:
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change