Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add downstream testing of roman_datamodels #263

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zacharyburnett
Copy link
Collaborator

This PR adds roman_datamodels downstream tests to the CI

Checklist

@zacharyburnett zacharyburnett self-assigned this May 12, 2023
@zacharyburnett zacharyburnett changed the title test roman_datamodels integration add downstream testing of roman_datamodels May 12, 2023
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0898a87) 93.54% compared to head (58d1dd7) 93.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #263   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files           4        4           
  Lines         124      124           
=======================================
  Hits          116      116           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zacharyburnett
Copy link
Collaborator Author

the roman_datamodels tests need data files; a possible solution could be adding instructions to clone roman_datamodels to the project directory in the toxenv

@braingram
Copy link
Collaborator

braingram commented Sep 20, 2024

If possible (and when available) it would be great to revive this PR.

Cloning roman_datamodels sounds like a good work-around. asdf does this for it's roman_datamodels downstream tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants