Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suffix for SIRS refpix output so it can be okified #9027

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Add suffix for SIRS refpix output so it can be okified #9027

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions jwst/regtest/test_nircam_image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,18 @@ def run_detector1pipeline(rtdata_module):

@pytest.fixture(scope="module")
def run_detector1pipeline_with_sirs(rtdata_module):
"""Run calwebb_detector1 on NIRCam imaging long data using the convolution kernel algorithm
Simple Improved Reference Subtraction (SIRS)"""
"""Run calwebb_detector1 on NIRCam imaging long data using SIRS.

SIRS is the convolution kernel algorithm - Simple Improved Reference Subtraction.
"""
rtdata = rtdata_module
rtdata.get_data("nircam/image/jw01538046001_03105_00001_nrcalong_uncal.fits")

# Run detector1 pipeline only on one of the _uncal files
args = ["calwebb_detector1", rtdata.input,
"--output_file=jw01538046001_03105_00001_nrcalong_sirs",
"--steps.refpix.refpix_algorithm=sirs",
"--steps.refpix.save_results=True"
"--steps.refpix.save_results=True",
]
Step.from_cmdline(args)

Expand Down Expand Up @@ -110,9 +113,9 @@ def test_nircam_image_sirs(run_detector1pipeline_with_sirs, rtdata_module, fitsd
"""Regression test of detector1 and image2 pipelines performed on NIRCam data."""
rtdata = rtdata_module
rtdata.input = "jw01538046001_03105_00001_nrcalong_uncal.fits"
output = "jw01538046001_03105_00001_nrcalong_refpix.fits"
output = "jw01538046001_03105_00001_nrcalong_sirs_refpix.fits"
rtdata.output = output
rtdata.get_truth("truth/test_nircam_image_stages/jw01538046001_03105_00001_nrcalong_refpix_SIRS.fits")
rtdata.get_truth("truth/test_nircam_image_stages/jw01538046001_03105_00001_nrcalong_sirs_refpix.fits")

fitsdiff_default_kwargs["rtol"] = 5e-5
fitsdiff_default_kwargs["atol"] = 1e-4
Expand Down
Loading