Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return opencv-python to a hard dependency #7499

Merged

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Mar 15, 2023

Closes #7409

This PR adds opencv-python to the hard dependencies in setup.cfg. This will fix installation issues for CRDS context >= jwst_1068.pmap (which enables snowball detection), but prevent installation on platforms that do not have a compiled binary for opencv-python, such as MacOS Mojave + Python 3.10.

If / when an alternative to opencv-python is implemented (JP-3120), this dependency can be removed.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@zacharyburnett zacharyburnett self-assigned this Mar 15, 2023
@github-actions github-actions bot added automation Continuous Integration (CI) and testing automation tools installation jump testing labels Mar 15, 2023
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (08b318e) 77.60% compared to head (ec77e21) 77.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7499      +/-   ##
==========================================
- Coverage   77.60%   77.59%   -0.01%     
==========================================
  Files         452      452              
  Lines       36095    36095              
==========================================
- Hits        28010    28009       -1     
- Misses       8085     8086       +1     
Flag Coverage Δ
nightly 77.60% <ø> (-0.01%) ⬇️
unit 49.56% <ø> (-0.01%) ⬇️

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, but let's be sure to get a regtest run against this branch before we approve and merge.

jwst/jump/tests/test_jump_step.py Show resolved Hide resolved
@hbushouse hbushouse added this to the Build 9.2 milestone Mar 15, 2023
@zacharyburnett zacharyburnett changed the title return opencv-python to a hard dependency return opencv-python to a hard dependency Mar 15, 2023
@hbushouse
Copy link
Collaborator

All of the failures from the regtest are expected differences due to more pixels being flagged by the snowball/shower correction in the jump step (which then propagates all the way downstream). So it looks good. I'm merging!

@hbushouse hbushouse merged commit 0f528ca into spacetelescope:master Mar 15, 2023
@zacharyburnett zacharyburnett deleted the opencv_hard_dependency branch March 15, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Continuous Integration (CI) and testing automation tools installation jump testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opencv dependency in stcal being optional causes uncaught error in jump step
2 participants