-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
return opencv-python
to a hard dependency
#7499
return opencv-python
to a hard dependency
#7499
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #7499 +/- ##
==========================================
- Coverage 77.60% 77.59% -0.01%
==========================================
Files 452 452
Lines 36095 36095
==========================================
- Hits 28010 28009 -1
- Misses 8085 8086 +1
see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK, but let's be sure to get a regtest run against this branch before we approve and merge.
opencv-python
to a hard dependency
All of the failures from the regtest are expected differences due to more pixels being flagged by the snowball/shower correction in the jump step (which then propagates all the way downstream). So it looks good. I'm merging! |
Closes #7409
This PR adds
opencv-python
to the hard dependencies insetup.cfg
. This will fix installation issues for CRDS context>= jwst_1068.pmap
(which enables snowball detection), but prevent installation on platforms that do not have a compiled binary foropencv-python
, such as MacOS Mojave + Python 3.10.If / when an alternative to
opencv-python
is implemented (JP-3120), this dependency can be removed.Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR