-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test opencv functionality separately #7414
test opencv functionality separately #7414
Conversation
Codecov ReportBase: 52.52% // Head: 52.52% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #7414 +/- ##
=======================================
Coverage 52.52% 52.52%
=======================================
Files 417 417
Lines 38087 38087
=======================================
Hits 20006 20006
Misses 18081 18081
*This pull request uses carry forward flags. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This PR breaks CRDS caching between CI jobs. The reason is that the The way to fix this is to move this |
This should be fixed by adding a dedicated caching job in https://github.com/spacetelescope/jwst/pull/7384/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f |
No, it is still broke, and that dedicated caching job makes it worse, as it runs https://github.com/spacetelescope/jwst/actions/runs/4009075221/jobs/6884024021#step:5:19 It has been broke since this PR. It used to restore ~350MB of reference files: https://github.com/spacetelescope/jwst/actions/runs/3758608010/jobs/6387151447#step:6:20 See the discussion here about why |
Addresses #7409
related to spacetelescope/stcal#136
This PR runs the tests requiring
opencv
in a separatetoxenv
withopencv-python
installed, to test whether conditional usage of ellipse construction is handled gracefully.Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR