Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send plugin ping while plugin is open if keep_active is True #3284

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Don't send plugin ping while plugin is open if keep_active is True #3284

wants to merge 1 commit into from
+10 −9

Conversation

rosteen
Copy link
Collaborator

@rosteen rosteen commented Nov 12, 2024

Cuts out the plugin ping messages when they aren't needed. Opening as draft because we probably want to add a separate variable to hide the keep_active toggle for Plot Options.

@rosteen rosteen added performance Performance related plugin Label for plugins common to multiple configurations labels Nov 12, 2024
@rosteen rosteen added this to the 4.1 milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javerbukh javerbukh Awaiting requested review from javerbukh javerbukh will be requested when the pull request is marked ready for review javerbukh is a code owner

@pllim pllim Awaiting requested review from pllim pllim will be requested when the pull request is marked ready for review pllim is a code owner

@kecnry kecnry Awaiting requested review from kecnry kecnry will be requested when the pull request is marked ready for review kecnry is a code owner

@bmorris3 bmorris3 Awaiting requested review from bmorris3 bmorris3 will be requested when the pull request is marked ready for review bmorris3 is a code owner

@haticekaratay haticekaratay Awaiting requested review from haticekaratay haticekaratay will be requested when the pull request is marked ready for review haticekaratay is a code owner

@cshanahan1 cshanahan1 Awaiting requested review from cshanahan1 cshanahan1 will be requested when the pull request is marked ready for review cshanahan1 is a code owner

@gibsongreen gibsongreen Awaiting requested review from gibsongreen gibsongreen will be requested when the pull request is marked ready for review gibsongreen is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
performance Performance related plugin Label for plugins common to multiple configurations
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
1 participant
@rosteen