Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonify plugin updates #3269

Open
wants to merge 42 commits into
base: main
Choose a base branch
from

Conversation

javerbukh
Copy link
Contributor

@javerbukh javerbukh commented Nov 6, 2024

Description

This pull request takes the work from james-trayford#3 and moves it into a PR for Jdaviz. There is now a plugin called "Sonify Data" which contains configuration options for sonifying a data cube. There are also options for which speaker the sound will come from, volume, and to start/stop the stream so the spectrum-at-spaxel tool can work as usual after sonifying the cube.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.
  • Add Sonify Data plugin which uses the Strauss package to turn a data cube into sound. [Sonify plugin updates #3269]

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

javerbukh and others added 25 commits July 31, 2024 17:27
- Fix sigcube alignment with other cubes [get rid of transpose]
- Add percentile cut option that enables some rough feature isolation without full continuum subtraction
- Protect against cubes w/NaNs
@github-actions github-actions bot added cubeviz plugin Label for plugins common to multiple configurations labels Nov 6, 2024
@javerbukh javerbukh added this to the 4.1 milestone Nov 6, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 41.35021% with 139 lines in your changes missing coverage. Please review.

Project coverage is 88.22%. Comparing base (0858f95) to head (b1d5806).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
jdaviz/configs/cubeviz/plugins/cube_listener.py 18.94% 77 Missing ⚠️
jdaviz/configs/cubeviz/plugins/viewers.py 40.67% 35 Missing ⚠️
...configs/cubeviz/plugins/sonify_data/sonify_data.py 64.93% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3269      +/-   ##
==========================================
- Coverage   88.78%   88.22%   -0.57%     
==========================================
  Files         125      127       +2     
  Lines       18832    19246     +414     
==========================================
+ Hits        16720    16979     +259     
- Misses       2112     2267     +155     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubeviz plugin Label for plugins common to multiple configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant