Extract on SubsetCreateMessage #3238
Draft
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plugin
rosteen
commented
Oct 21, 2024
| @@ -262,6 +262,7 @@ def _aperture_items_changed(self, msg): | |||
| self._extract_in_new_instance(subset_lbl=subset_lbl, | |||
| auto_update=True, add_data=True) | |||
| except Exception: | |||
| raise | |||
There was a problem hiding this comment.
This is here for debugging to expose the error.
rosteen
commented
Oct 21, 2024
Comment on lines
+1878
to
+1879
| self.hub.subscribe(self, SubsetCreateMessage, | ||
| handler=lambda msg: self._update_subset(msg.subset)) |
There was a problem hiding this comment.
I hoped that I could just replace the trigger for this from SubsetUpdateMessage to SubsetCreateMessage, but it didn't work.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3238 +/- ##
==========================================
+ Coverage 88.46% 88.62% +0.15%
==========================================
Files 125 125
Lines 18677 18779 +102
==========================================
+ Hits 16522 16642 +120
+ Misses 2155 2137 -18 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to be a compatibility patch for glue-viz/glue#2515, but currently isn't working. Opening this PR to share with SMEs @astrofrog @dhomeier. To reproduce the error I mentioned in here, open Cubeviz and try to use the Spectral Extraction plugin.