-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notebook for NIRCam WFSS Box Extraction #246
Add notebook for NIRCam WFSS Box Extraction #246
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Waiting on Nor for final approval of the notebook. But otherwise I think we can consider the science review complete, as I looked everything over after Nor gave me the notebook. |
If I'm interpreting the notes correctly, it looks like the Execution and Validation initially failed on the calls to run_pipeline_steps(). But without detailed notes, it's note clear to me why they failed. Everything works for me locally. |
@camipacifici this is ready for Technical Review |
Great! Added to the queue. Any time constraints on the NIRCam side? |
No time constraints. |
2f0e6c6
to
2a87538
Compare
Hi @bhilbert4! For personal or other offsite uses the environment settings for CRDS needs to be manually in order for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Execution and Validation errors were resolved by adding a cell block that checks to see if the user/CI has their CRDS environment set up, if so continue, and if not, set up the environment so the pipeline has access to references files when necessary. With this, all CI is green.
This notebook checklist has been made available to us by the the Notebooks For All team.
Its purpose is to serve as a guide for both the notebook author and the technical reviewer highlighting critical aspects to consider when striving to develop an accessible and effective notebook.
The First Cell
<h1>
or# in markdown
).1., 2.,
etc. in Markdown).The Rest of the Cells
#
in Markdown) used in the notebook.Text
Code
Images
All images (jpg, png, svgs) have an image description. This could be
alt
property)alt
attribute with no value)Any text present in images exists in a text form outside of the image (this can be alt text, captions, or surrounding text.)
Visualizations
All visualizations have an image description. Review the previous section, Images, for more information on how to add it.
Visualization descriptions include
All visualizations and their parts have enough color contrast (color contrast checker) to be legible. Remember that transparent colors have lower contrast than their opaque versions.
All visualizations convey information with more visual cues than color coding. Use text labels, patterns, or icons alongside color to achieve this.
All visualizations have an additional way for notebook readers to access the information. Linking to the original data, including a table of the data in the same notebook, or sonifying the plot are all options.