Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display translate button outside of the menu if detected content lang… #390

Merged
merged 3 commits into from
Aug 25, 2024
Merged

display translate button outside of the menu if detected content lang… #390

merged 3 commits into from
Aug 25, 2024

Conversation

4vanger
Copy link
Collaborator

@4vanger 4vanger commented Aug 23, 2024

…uage is different from user's preferred lang
per discussion
preferred lang: ua

preferred lang: ru

@4vanger
display translate button outside of the menu if detected content lang…
c01dd07 
…uage is different from user's preferred lang
@4vanger 4vanger requested a review from a team August 23, 2024 17:12
Aivean
Aivean previously approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@Aivean Aivean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise, but there might be an issue with preferred languages other than the most frequent one — essentially all comments will have the button displayed inline, which arguably is not the best UX. Maybe add a setting how to display the button?

@4vanger 4vanger merged commit 9c02b3d into dev Aug 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aivean Aivean Aivean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@4vanger @Aivean