Extract metadata from self-hosted media urls and add it to images and videos #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Aivean
force-pushed
the
add-img-video-dimensions-from-orb-media
branch
from
4dffcb1
to
40cbdea
Compare
|
Looks like I managed to fix the styles, but there are still some issues with layout shifts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To recap, the basic idea is to make pictshare encode the metadata (dimensions) into the returned urls.
Backend decrypts such urls and adds metadata to
imgandvideo.Caveat:
max-widthandmax-heightin image dimensions no longer work as expected.