Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Warning to Pull Requests in Tutorial #317

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Warning to Pull Requests in Tutorial #317

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3566e50
add a warning to making a pull request
scrivoy Oct 10, 2024
886074e
Revise PR visibility warning for clarity
scrivoy Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/en/general-development/setup/git-for-the-ss14-developer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,10 @@ Now, the fun part. We'll go to GitHub now and make a pull request for our funny

Add a description, a nice title, some screenshots, and hopefully it gets merged.

```admonish warning title="Don't do it now"
Any pull request made to the official repository will be publicly visible and open for review and comments by anyone. Ensure that your changes are thoroughly reviewed and ready for official evaluation. If you only want to test, consider creating the PR in your own fork.
```

## 6. Updating our repository

Maybe it's been a while, a week or two, since your last pull request, and you'd like to make another. Before you do anything, you need to download (**pull**) the code changes from the main SS14 repository into your local repository. If you don't, you'll have out-of-date code and your local changes may not be accurate to how the game will actually run--you might even get **merge conflicts** when you try to PR.
Expand Down
Loading