Fix map netId completions #5495
Conversation
|
|
||
| return Components<MapComponent>(string.Empty, entManager, limit: int.MaxValue); // faster just to pass the max value than bother unlimiting it. | ||
| } |
There was a problem hiding this comment.
At least it make it like 100 or something if you want higher than 20.
There was a problem hiding this comment.
But if you have more than 100 maps it just wont work as expected.
There was a problem hiding this comment.
The limit only applies to matching uids, so as you start typing the uid it would still eventually show the completions for the map you want, even if there are far more than 20 maps. It only really matters if you really want to get given the completion tooltip with 100+ maps that you want to manually read through to find the right uid.
Though TBH I'm not even sure if having the limit implemented like that is really of any use. Even with it there, the helper should still only ever be used when you know there's only going to be a handful of components. Calling with with something like TransformComponent could still result in it iterating over almost all entities . E.g., in my toolshed PR I just arbitrarily limited it to EntityManager.Count<TComp>() <= 128
Map netId's completion helpers didn't work because empty strings fail NetEntity.TryParse. I special cased it.
Also made the helper pull all maps because it would be unhelpful if it didn't.