Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NASA Challenge_[@katiehughes1]_[Space ROS Gazebo Demos]_[closes #47] #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

katie-hughes
Copy link

@katie-hughes katie-hughes commented Aug 27, 2024

This is a submission for the NASA Space ROS Sim Summer Sprint Challenge written by @david-dorf and I. The main details of our submission are on the README.md introduced in the spaceros_gz_demos package we added to this repo. We introduce four new demos that run in Gazebo Harmonic with the relevant topics for sending robot controls and reading sensor information bridged to ROS. This includes simulated worlds with robots on the Moon, Mars, Enceladus, and in orbit above Earth. We also provide a Dockerfile that can be used to run these simulations in spaceros_gz_demos/docker that is built upon the base Space ROS docker image, as well as some scripts to help with building and running the image.

This PR is a lot of lines, but most of the lines come from the mesh files added for the different models. The relevant ROS code added is in spaceros_gz_demos/launch.

Relevant issue: #47

space.mp4

@mkhansenbot mkhansenbot self-requested a review September 5, 2024 16:16
@mkhansenbot
Copy link
Contributor

Hi @katie-hughes - thanks for your submission! There are a few housekeeping things I need you to do per our contribution guidelines. First, please file an issue with a feature request for this demo, then update your commit message and the title of this PR to include the issue #. Second, please change your docker_build.sh to build.sh so that our new CI build workflow will build the PR automatically. Third, please change your docker_start.sh to run.sh (see the latest README file, we're trying to standardize). Finally, please rebase and resolve the conflict with the README file, then re-push your branch so that our CI will run the build. Thanks!

@katie-hughes
Copy link
Author

@mkhansenbot Thanks for letting me know. I just updated our docker related scripts to match the new CI steps, and resolved the merge conflict in the readme.
With regards to linking to a relevant issue -- I thought that we could just reference "NASA Space ROS Sim Summer Sprint Challenge" (in the attached document). I could create one if it's necessary though.

Challenge Brief - NASA Space ROS Sim Summer Sprint Challenge.pdf

Let me know if there are any other changes that need to be made!

@mkhansenbot
Copy link
Contributor

Yes, please add a "Feature request" issue (there's now a template when you create a new issue), with a brief description of the demo, then update the commit messages to refer to that issue. Also add the issue number to the PR title. Thanks again!

spaceros_gz_demos/README.md Outdated Show resolved Hide resolved
@katie-hughes katie-hughes changed the title NASA Challenge_@katiehughes1_Space_ROS_Gazebo_Demos NASA Challenge_[@katiehughes1]_[Space ROS Gazebo Demos_[closes #47] Sep 7, 2024
@katie-hughes katie-hughes changed the title NASA Challenge_[@katiehughes1]_[Space ROS Gazebo Demos_[closes #47] NASA Challenge_[@katiehughes1]_[Space ROS Gazebo Demos]_[closes #47] Sep 7, 2024
@mkhansenbot
Copy link
Contributor

@katie-hughes - I just changed the build workflow to cd into the folder first, then rebased your branch

@katie-hughes
Copy link
Author

@mkhansenbot sounds good, will just need to update the docker related scripts so that they can run from this new location

@mkhansenbot mkhansenbot dismissed their stale review September 12, 2024 18:24

Outdated review

@Bckempa Bckempa added the Summer Sprint NASA Space ROS Sim Summer Sprint Challenge 2024 label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Summer Sprint NASA Space ROS Sim Summer Sprint Challenge 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants