Improve mounted check to support symlinks #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SlashDashAndCash
force-pushed
the
handle-symlink-dev-paths
branch
3 times, most recently
from
55bf88f to
294c1e5
Compare
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (1)
libraries/fs.rb:37
- The new behavior of raising an exception for invalid parameters in the 'mounted?' method should be covered by tests.
raise 'Invalid parameters passed to method "mounted?"'
damacus
added
the
Release: Minor
3 tasks
|
Can you rebase, or allow us to rebase and I'll merge this in. |
SlashDashAndCash
force-pushed
the
handle-symlink-dev-paths
branch
from
294c1e5 to
f68356e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the mounted? check
Description
This pull request is similar to 130 by jrmycanady but also canonicalizes device paths in /proc/mounts. This is necessary because device paths in /prod/mount can be symlinks as well. For example, /dev/mapper/system-root referes to /dev/dm-0.
Issues Resolved
129 - filesystem tries to run mkfs every time when /dev/disk/by-id device path is used
Check List
## Unreleased