Add input validation for label property #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we're blocked on LVM being updated. I've just move it across to Sous-Chefs so it needs adopting and fixing to work with Chef 17 |
|
@damacus I opened this up: sous-chefs/lvm#210 |
ramereth
added
the
Release: Minor
Generated by 🚫 Danger |
Signed-off-by: Jason Barnett <[email protected]>
ramereth
force-pushed
the
bugfix/add-validation-to-label-length
branch
from
792fd22 to
fcb7cea
Compare
ramereth
previously approved these changes
Oct 14, 2021
|
@jasonwbarnett can you please fix the issue on this PR? I rebased it and the other issues are fixed |
|
Released as: 4.1.0 |
|
@damacus thanks for handling this 🚀. Totally dropped off my radar. |
|
Mine too! My inbox is just a mess so I'm glad I found this nice PR to apply 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mkfs.xfshas a maximum of 12 characters for the label (-L).Ideally this would be merged after #105
Issues Resolved
N/A
Check List
## Unreleased