-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add estimation for the expires time for transferring large files #281
Open
bbbco
wants to merge
1
commit into
sous-chefs:main
Choose a base branch
from
bbbco:s3_estimate_time
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@bbbco did you want us to be able to merge this? It seems reasonable, but we can't unless you legally permit us to by using a DCO Signed-off-by. |
bbbco
changed the title
Add estimation for the expires time for transferring large files
Add estimation for the expires time for transferring large files
Aug 30, 2018
bbbco
changed the title
Add estimation for the expires time for transferring large files
Add estimation for the expires time for transferring large files | Signed-off-by: Brian Goad <[email protected]>
Aug 30, 2018
bbbco
changed the title
Add estimation for the expires time for transferring large files | Signed-off-by: Brian Goad <[email protected]>
Add estimation for the expires time for transferring large files
Aug 30, 2018
Signed-off-by: Brian Goad <[email protected]>
bbbco
force-pushed
the
s3_estimate_time
branch
from
August 30, 2018 04:03
0d0d10d
to
620100a
Compare
@josephholsten signed |
tas50
added
Triage: Needs Information
and removed
Status: Pending Contributor Response
labels
Jan 4, 2019
Ishaan28malik
approved these changes
Sep 13, 2019
xorima
approved these changes
Sep 28, 2023
xorima
approved these changes
Sep 28, 2023
xorima
approved these changes
Sep 28, 2023
xorima
approved these changes
Sep 29, 2023
lolz at all the approvals of this five year old PR. @xorima you might want to check on whatever bot you have automating PRs these days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes the download I am trying will timeout while finishing to download because it is a very large file (multiple GBs). This change allows you to define a timeout with the
expires
attribute; otherwise it employs some basic math to determine how long to set the timeout.Issues Resolved
[List any existing issues this PR resolves]
Check List