Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/sg: add lock to secrets.Store CRUD #64397

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix/sg: add lock to secrets.Store CRUD #64397

wants to merge 1 commit into from

Conversation

bobheadxi
Copy link
Member

@bobheadxi bobheadxi commented Aug 9, 2024 •
edited
Loading

https://sourcegraph.slack.com/archives/C04MYFW01NV/p1723226457106239

Test plan

go build -o ./sg ./dev/sg && ./sg install -f -p=false
sg start dotcom

@bobheadxi bobheadxi requested a review from eseliger August 9, 2024 18:12
@cla-bot cla-bot bot added the cla-signed label Aug 9, 2024
@bobheadxi bobheadxi requested a review from a team August 9, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burmudar burmudar burmudar approved these changes

@eseliger eseliger Awaiting requested review from eseliger

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobheadxi @burmudar