Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] CS-5775 - handle translations in tpls via CLI #1108

Open
wants to merge 3 commits into
base: v4.4
Choose a base branch
from

Conversation

takeit
Copy link
Contributor

@takeit takeit commented May 7, 2015

Loading translation files in CLI is not needed. Less execution time.

@ahilles107
Copy link
Contributor

how about templates with translations generated by cli? example: anouncements notifications?

@takeit
Copy link
Contributor Author

takeit commented May 7, 2015

anouncements notifications ? which files exactly ?

@ahilles107
Copy link
Contributor

don't have exact files but think - if you will want build some kind reminders or notifications system where you send mail with content from translated template file - it will fail. It close many doors for us and plugin developers.

@m038
Copy link
Contributor

m038 commented May 7, 2015

Yeah, now i think of it, not sure if this is a good idea. What about if you want to translate cli strings?

@ahilles107
Copy link
Contributor

@m038 translator will work anyway, just translation files for current publication theme will be not loaded.

@ahilles107
Copy link
Contributor

@takeit how performance improvement looks on blackfire?

@takeit
Copy link
Contributor Author

takeit commented May 7, 2015

okay agree, so I found a bug, because when you will use template service and execute it via cli it will throw You cannot create a service ("request") of an inactive scope ("request") because we are calling request in CampTemplate. Im gonna fix it.

@ahilles107
Copy link
Contributor

i'm not against it - but we should leave option for developers to load those translations somehow with cli (command should provide langauge and publication/issue numbers)

@takeit takeit changed the title skip translations files loading in cli [WIP] load translations in tpls via CLI May 7, 2015
@takeit takeit changed the title [WIP] load translations in tpls via CLI [WIP] CS-5775 - handle translations in tpls via CLI May 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants