-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] CS-5775 - handle translations in tpls via CLI #1108
base: v4.4
Are you sure you want to change the base?
Conversation
how about templates with translations generated by cli? example: anouncements notifications? |
anouncements notifications ? which files exactly ? |
don't have exact files but think - if you will want build some kind reminders or notifications system where you send mail with content from translated template file - it will fail. It close many doors for us and plugin developers. |
Yeah, now i think of it, not sure if this is a good idea. What about if you want to translate cli strings? |
@m038 translator will work anyway, just translation files for current publication theme will be not loaded. |
@takeit how performance improvement looks on blackfire? |
okay agree, so I found a bug, because when you will use template service and execute it via cli it will throw |
i'm not against it - but we should leave option for developers to load those translations somehow with cli (command should provide langauge and publication/issue numbers) |
Loading translation files in CLI is not needed. Less execution time.