Added performance.now() and canceled rAF after stop() #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, operations after
stop()
.With the proposed changes.
I took the liberty of adjusting the init/start/stop lifecycle and time handling in function of the rAF callback lifecycle.
context.dt
is always0
because there is no previous framecontext.now
andcontext.dt
hold meaningful values only whencontext.running
istrue
context.millis
is the overall time spent in the animation loop [1] , not the context's lifetimecontext.st
(start time, in the spirit of.dt
) was added in order to easily determine the lifetime of the contextI tried to match your coding style, but some air may be missing here and there. :)
[1] Minus the last frame, which is a shortcoming that might need to be addressed.