Add allChar function, fix #281 #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function corresponds to `re.allchar` in http://smtlib.cs.uiowa.edu/theories-UnicodeStrings.shtml. It is implemented in the Z3 and CVC4 solvers.
Add one test for unicode support. Z3 supports Unicode (https://microsoft.github.io/z3guide/docs/theories/Strings), but CVC4 does not (see http://cvc4.cs.stanford.edu/wiki/Strings, under limitations).
and fix the corresponding test.
|
Tested locally. Seems to work fine. Larger Regex tests will be done as soon as there is an application using this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function corresponds to
re.allcharin http://smtlib.cs.uiowa.edu/theories-UnicodeStrings.shtml. It is implemented by the Z3 and CVC4 solvers. It was previously removed by mistake. Fixes #281.Running tests with
ant tests(before or after applying these changes) yields test errors. CVC4 tests all fail and some Z3 tests fail. For Z3 tests, this does not happen when they are run individually. I am unsure if this is expected or if I should change the way I run tests. However, the newly added test case passes with Z3.