-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nvidia] Capture more nvidia commands #3777
base: main
Are you sure you want to change the base?
Conversation
Capture commands related to nvidia container toolkit. Related: RHEL-58172 Signed-off-by: Jose Castillo <[email protected]>
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me. I re-started timeouted tests that failed.
self.add_service_status("nvidia-persistenced") | ||
self.add_service_status("nvidia-fabricmanager") | ||
self.add_service_status("nvidia-toolkit-firstboot") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious, would it good to add journal for all these too. i.e. if one only wants to enable the nvidia
plugin and nothing else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. I'll addthe journals as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these are added to the services
tuple, it can be used for plugin enablement as well as automatically getting the journal and service status.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. Shall I add the three services to the plugin enablement? We have its journal capture a bit different:
self.add_journal(boot=0, identifier='nvidia-persistenced')
But a quick test I did in a RHEL AI image showed that the nvidia-persistenced service is captured correctly. My only doubt is the 'boot=0' option.
Capture commands related to nvidia container toolkit.
Related: RHEL-58172
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines