Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[leapp] improve plugin enablement and add more collected files #3776

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

evgeni
Copy link
Contributor

@evgeni evgeni commented Sep 11, 2024

The leapp-repository package was renamed to leapp-upgrade-elXtoY
in [1], and while we could list all possible combinations here,
the main leapp package should be enough to trigger this plugin

While at it, also enable plugin when /var/lib/leapp exists, as
after an upgrade is performed, users often uninstall the leapp packages,
but it can still be beneficial for SOS to collect data about the fact
that this is a system that was upgraded (and data about the upgrade) and
/var/lib/leapp shows exactly that.

Also include /etc/migration-results and /var/log/leapp/answerfile in
collected files.

[1] oamg/leapp-repository@924c398


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3776
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@arif-ali
Copy link
Member

Hi @evgeni can you squash your commits please, before we can land the PR, TiA

Also, just making sure, does the answerfile, or any new files that are being collected have passwords that need obfuscating?

@evgeni
Copy link
Contributor Author

evgeni commented Sep 11, 2024

@arif-ali I can sure, just thought it's cleaner if they are separate as they change different aspects of the plugin

And no, to the best of my knowledge, the answers file should not contain any sensitive data, right @pirat89?

The `leapp-repository` package was renamed to `leapp-upgrade-elXtoY`
in [1], and while we could list all possible combinations here,
the main `leapp` package should be enough to trigger this plugin

While at it, also enable plugin when /var/lib/leapp exists, as
after an upgrade is performed, users often uninstall the leapp packages,
but it can still be beneficial for SOS to collect data about the fact
that this is a system that was upgraded (and data about the upgrade) and
/var/lib/leapp shows exactly that.

Also include /etc/migration-results and /var/log/leapp/answerfile in
collected files.

[1] oamg/leapp-repository@924c398

Signed-off-by: Evgeni Golov <[email protected]>
@evgeni evgeni changed the title leapp plugin improvements [leapp] improve plugin enablement and add more collected files Sep 11, 2024
@evgeni
Copy link
Contributor Author

evgeni commented Sep 11, 2024

squashed

@pirat89
Copy link

pirat89 commented Sep 11, 2024

@arif-ali I can sure, just thought it's cleaner if they are separate as they change different aspects of the plugin

And no, to the best of my knowledge, the answers file should not contain any sensitive data, right @pirat89?

So far there are not any sensitive data required by us. We currently require people to provide just True/False answers.

@TurboTurtle TurboTurtle merged commit a946343 into sosreport:main Sep 11, 2024
36 checks passed
@evgeni evgeni deleted the leapp branch September 11, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants