Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bootc] Add new plugin bootc #3772

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

jcastill
Copy link
Member

@jcastill jcastill commented Sep 5, 2024

Add new plugin to support bootable
containers tool bootc.

Related: RHEL PLMCORE-10590


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

@jcastill
Copy link
Member Author

jcastill commented Sep 5, 2024

Setting this as draft because is still a WIP.

Regarding the capture of /usr/lib/ostree/prepare-root.conf - I can move it to the rpmostree plugin if you all think it's better to gather it there.

@arif-ali I couldn't find the bootc tool in Ubuntu (I've searched via apt-file search bootc and other apt commands, and I can see that you guys distribute bootcd and bootctl. Could you check if I should add an entry for Ubuntu as well?

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3772
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@arif-ali
Copy link
Member

arif-ali commented Sep 6, 2024

@arif-ali I couldn't find the bootc tool in Ubuntu (I've searched via apt-file search bootc and other apt commands, and I can see that you guys distribute bootcd and bootctl. Could you check if I should add an entry for Ubuntu as well?

I couldn't find it either, so no need to enable it for Ubuntu

Copy link
Member

@arif-ali arif-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am presuming the conf file has been checked for any obfuscation requirements?

sos/report/plugins/bootc.py Show resolved Hide resolved
@jcastill
Copy link
Member Author

jcastill commented Sep 6, 2024

Yes, I checked if we store any password or secret in there and the documentation I've read doesn't indicate that we do.

@jcastill jcastill marked this pull request as ready for review September 10, 2024 15:26
Comment on lines 20 to 22
packages = (
'bootc',
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: this can be a single line.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to push the fix ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do it tomorrow morning

@TurboTurtle
Copy link
Member

Looks fine overall, just the nit from Arif and myself.

Add new plugin to support bootable
containers tool bootc.

Related: RHEL PLMCORE-10590

Signed-off-by: Jose Castillo <[email protected]>
@TurboTurtle TurboTurtle merged commit a48c0eb into sosreport:main Sep 14, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants