-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bootc] Add new plugin bootc #3772
[bootc] Add new plugin bootc #3772
Conversation
Setting this as draft because is still a WIP. Regarding the capture of /usr/lib/ostree/prepare-root.conf - I can move it to the rpmostree plugin if you all think it's better to gather it there. @arif-ali I couldn't find the bootc tool in Ubuntu (I've searched via |
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
I couldn't find it either, so no need to enable it for Ubuntu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am presuming the conf file has been checked for any obfuscation requirements?
Yes, I checked if we store any password or secret in there and the documentation I've read doesn't indicate that we do. |
eb1439b
to
42e8a39
Compare
sos/report/plugins/bootc.py
Outdated
packages = ( | ||
'bootc', | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: this can be a single line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack, fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget to push the fix ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do it tomorrow morning
Looks fine overall, just the nit from Arif and myself. |
Add new plugin to support bootable containers tool bootc. Related: RHEL PLMCORE-10590 Signed-off-by: Jose Castillo <[email protected]>
42e8a39
to
df9894e
Compare
Add new plugin to support bootable
containers tool bootc.
Related: RHEL PLMCORE-10590
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines